Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

test: enable bitswap tests on windows#1483

Merged
alanshaw merged 5 commits into
masterfrom
test/enable-bitswap-win-20180802
Aug 7, 2018
Merged

test: enable bitswap tests on windows#1483
alanshaw merged 5 commits into
masterfrom
test/enable-bitswap-win-20180802

Conversation

@alanshaw

@alanshaw alanshaw commented Aug 2, 2018

Copy link
Copy Markdown
Member

closes #1313

@ghost ghost assigned alanshaw Aug 2, 2018
@ghost ghost added the status/in-progress In progress label Aug 2, 2018
@alanshaw alanshaw force-pushed the test/enable-bitswap-win-20180802 branch from dae349f to 414583b Compare August 6, 2018 11:06
@alanshaw

alanshaw commented Aug 6, 2018

Copy link
Copy Markdown
Member Author

@achingbrain not sure why but the files.ls ordering is incorrect:

1) interface-ipfs-core over ipfs-api tests .files.ls should ls directory:

    Uncaught AssertionError: expected [ Array(2) ] to deeply equal [ Array(2) ]
    + expected - actual

     [
       {
         "hash": ""
    -    "name": "b"
    +    "name": "lv1"
         "size": 0
         "type": 0
       }
       {
         "hash": ""
    -    "name": "lv1"
    +    "name": "b"
         "size": 0
         "type": 0
       }
     ]
    
    at ipfs.files.ls (node_modules/interface-ipfs-core/js/src/files/ls.js:56:27)
    at transform (node_modules/ipfs-api/src/files/ls.js:8:3)
    at send (node_modules/ipfs-api/src/utils/send-request.js:217:7)
    at f (node_modules/once/once.js:25:25)
    at streamToValue (node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
    at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
    at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:37:43)
    at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:630:14)
    at afterWrite (node_modules/readable-stream/lib/_stream_writable.js:492:3)
    at _combinedTickCallback (internal/process/next_tick.js:144:20)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

2) interface-ipfs-core over ipfs-api tests .files.ls should ls -l directory:

    Uncaught AssertionError: expected [ Array(2) ] to deeply equal [ Array(2) ]
    + expected - actual

     [
       {
    +    "hash": "QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn"
    +    "name": "lv1"
    +    "size": 0
    +    "type": 1
    +  }
    +  {
         "hash": "QmcZojhwragQr5qhTeFAmELik623Z21e3jBTpJXoQ9si1T"
         "name": "b"
         "size": 13
         "type": 0
       }
    -  {
    -    "hash": "QmUNLLsPACCz1vLxQVkXqqLX5R1X345qqfHbsf67hvA3Nn"
    -    "name": "lv1"
    -    "size": 0
    -    "type": 1
    -  }
     ]
    
    at ipfs.files.ls (node_modules/interface-ipfs-core/js/src/files/ls.js:76:27)
    at transform (node_modules/ipfs-api/src/files/ls.js:8:3)
    at send (node_modules/ipfs-api/src/utils/send-request.js:217:7)
    at f (node_modules/once/once.js:25:25)
    at streamToValue (node_modules/ipfs-api/src/utils/stream-to-json-value.js:30:5)
    at concat (node_modules/ipfs-api/src/utils/stream-to-value.js:12:22)
    at ConcatStream.<anonymous> (node_modules/concat-stream/index.js:37:43)
    at finishMaybe (node_modules/readable-stream/lib/_stream_writable.js:630:14)
    at afterWrite (node_modules/readable-stream/lib/_stream_writable.js:492:3)
    at _combinedTickCallback (internal/process/next_tick.js:144:20)
    at process._tickDomainCallback (internal/process/next_tick.js:218:9)

@alanshaw

alanshaw commented Aug 6, 2018

Copy link
Copy Markdown
Member Author

I've added skips for the problematic files.ls tests temporarily until ipfs-inactive/js-ipfs-mfs#7 can be resolved (these tests are not relevant to the changes in this PR).

@alanshaw

alanshaw commented Aug 6, 2018

Copy link
Copy Markdown
Member Author

Same for ipfs-inactive/js-ipfs-mfs#8

@alanshaw

alanshaw commented Aug 6, 2018

Copy link
Copy Markdown
Member Author

closes #1313

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw force-pushed the test/enable-bitswap-win-20180802 branch from 337975e to e9166fd Compare August 7, 2018 09:13
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw

alanshaw commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

Updated to latest ipfsd-ctl and everything is happay again! hooray \o/

@alanshaw alanshaw merged commit 29b5b33 into master Aug 7, 2018
@ghost ghost removed the status/in-progress In progress label Aug 7, 2018
@alanshaw alanshaw deleted the test/enable-bitswap-win-20180802 branch August 7, 2018 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Bitswap tests on Windows

1 participant